Skip to content

fix: update shell local symlink path to packages/shell#12

Closed
brfid wants to merge 1 commit intomainfrom
fix/dotfiles-packages-path
Closed

fix: update shell local symlink path to packages/shell#12
brfid wants to merge 1 commit intomainfrom
fix/dotfiles-packages-path

Conversation

@brfid
Copy link
Copy Markdown
Owner

@brfid brfid commented Apr 1, 2026

Summary

  • Updates the ln -sfn path in scripts/setup-dotfiles.sh from $DOTFILES/shell/... to $DOTFILES/packages/shell/...
  • .stowrc now includes --dir=packages, so stow resolves automatically from there; the manual symlink path needed to match

Test plan

  • Run scripts/setup-dotfiles.sh on a fresh edcloud machine and verify the symlink at ~/.config/shell/local points to the correct file

🤖 Generated with Claude Code

.stowrc now includes --dir=packages so stow resolves from there;
update the manual ln path to match.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 1, 2026 19:20
@brfid brfid closed this Apr 1, 2026
@brfid brfid deleted the fix/dotfiles-packages-path branch April 1, 2026 19:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the edcloud dotfiles bootstrap script to match a changed dotfiles repo layout where the shell stow package now lives under packages/shell.

Changes:

  • Update the hard-coded ln -sfn source path for the profile-specific shell local file to "$DOTFILES/packages/shell/...".

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +18 to 20
ln -sfn "$DOTFILES/packages/shell/.config/shell/local.d/edcloud.sh" \
"$HOME/.config/shell/local"

Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ln -sfn will happily create/update ~/.config/shell/local even if the source file path is wrong or missing, leaving a broken symlink while the script still prints success. Since this path just changed (and depends on the external dotfiles repo layout), add an explicit check that the source file exists (and fail with a clear error) before running ln, optionally with a fallback to the previous location if you need to support older dotfiles checkouts.

Suggested change
ln -sfn "$DOTFILES/packages/shell/.config/shell/local.d/edcloud.sh" \
"$HOME/.config/shell/local"
LOCAL_SRC="$DOTFILES/packages/shell/.config/shell/local.d/edcloud.sh"
if [ ! -f "$LOCAL_SRC" ]; then
echo "Error: expected shell local config not found at: $LOCAL_SRC"
echo "Ensure your dotfiles repo is up to date and the edcloud profile file exists."
exit 1
fi
mkdir -p "$HOME/.config/shell"
ln -sfn "$LOCAL_SRC" "$HOME/.config/shell/local"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants