Skip to content

fix: update shell local symlink path to packages/shell #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brfid wants to merge 1 commit into from
Closed

fix: update shell local symlink path to packages/shell #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/setup-dotfiles.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ cd "$DOTFILES"
stow --target="$HOME" bash shell nvim gh claude vscode tmux systemd-user git

# Profile-specific shell local
ln -sfn "$DOTFILES/shell/.config/shell/local.d/edcloud.sh" \
ln -sfn "$DOTFILES/packages/shell/.config/shell/local.d/edcloud.sh" \
"$HOME/.config/shell/local"

Comment on lines +18 to 20
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ln -sfn will happily create/update ~/.config/shell/local even if the source file path is wrong or missing, leaving a broken symlink while the script still prints success. Since this path just changed (and depends on the external dotfiles repo layout), add an explicit check that the source file exists (and fail with a clear error) before running ln, optionally with a fallback to the previous location if you need to support older dotfiles checkouts.

Suggested change
ln -sfn "$DOTFILES/packages/shell/.config/shell/local.d/edcloud.sh" \
"$HOME/.config/shell/local"
LOCAL_SRC="$DOTFILES/packages/shell/.config/shell/local.d/edcloud.sh"
if [ ! -f "$LOCAL_SRC" ]; then
echo "Error: expected shell local config not found at: $LOCAL_SRC"
echo "Ensure your dotfiles repo is up to date and the edcloud profile file exists."
exit 1
fi
mkdir -p "$HOME/.config/shell"
ln -sfn "$LOCAL_SRC" "$HOME/.config/shell/local"

Copilot uses AI. Check for mistakes.
echo "Dotfiles linked for edcloud."
Loading