docker base fix: Fix Entrypoint Corruption #497
Open
eminmeydanoglu wants to merge 6 commits intomainfrom
Open
Conversation
senceryazici
reviewed
Jan 5, 2026
Member
senceryazici
left a comment
senceryazici
left a comment
There was a problem hiding this comment.
This PR needs a rebase on #515 though
| username: ${{ github.repository_owner }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Create PR manifest and push |
Member
There was a problem hiding this comment.
Why not just put this step on the create manifest job above as a step? You can still use the if check since this is run: which gives you full bash access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous sed command incorrectly concatenated exec "$@" with source ... due to a newline escaping issue, creating the invalid command zshsource.
Fix: Switched to using sed insert mode (/exec/i ...) to safely insert the source command on a separate line.