Skip to content

StashBuildTrigger: Only allow jobs derived from AbstractProject#70

Merged
jakub-bochenski merged 1 commit intojenkinsci:masterfrom
proski:no-pipelines-yet
Apr 9, 2019
Merged

StashBuildTrigger: Only allow jobs derived from AbstractProject#70
jakub-bochenski merged 1 commit intojenkinsci:masterfrom
proski:no-pipelines-yet

Conversation

@proski
Copy link

@proski proski commented Mar 29, 2019

This hides Stash Pull Request Builder from the build trigger list in the pipeline configuration. Pipelines are currently unsupported.

Once the pipelines are supported, isApplicable will be adjusted to include them.

Pipelines are not currently supported. No need to frustrate users. Only
accept jobs derived from AbstractProject.
@jakub-bochenski
Copy link

@jimklimov I would like to merge this ASAP to reduce user confusion

@jakub-bochenski jakub-bochenski merged commit c40510b into jenkinsci:master Apr 9, 2019
@proski proski deleted the no-pipelines-yet branch April 9, 2019 16:23
@Chocrates
Copy link

@proski Why do you say Pipelines are unsupported? As of version 1.7 of this plugin, the plugin worked fine with pipelines. I will test master against my set up (after rolling this change back) to confirm if it still works shortly.

@proski
Copy link
Author

proski commented Apr 18, 2019

@proski Why do you say Pipelines are unsupported? As of version 1.7 of this plugin, the plugin worked fine with pipelines. I will test master against my set up (after rolling this change back) to confirm if it still works shortly.

There was no version 1.7. The last released versions were 1.6.0, 1.7.0, 1.7.1, 1.8:
https://github.com/jenkinsci/stash-pullrequest-builder-plugin/releases

Maybe you used some unofficial version? Or maybe you mean pipeline views? Or maybe you mean that pipeline jobs can coexist with free-style projects that use this plugin?

Knowing the amount of changes in #69, I doubt that version 1.7.0 or 1.7.1 would do anything useful in a pipeline project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants