Support PRIDE / SDRF input#445
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…y/ tool-namespaced directories
…lesheet header seed
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.5.1. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
|
@have you tested pridepy with aspera in production? How does it works? |
|
@ypriverol I did (on my VM (IPv6)) for 140 raw files:
|
d4straub
left a comment
There was a problem hiding this comment.
Looks good.
Nothing serious, but I dislike the resource allocations in conf/modules.conf.
And the usage.md might benefit from input documentation.
About Edit edit: New test runs through, but no space on device. Will shrink sdrf sheet to only 1 file instead of 2 after review: Afaik its possible to increase the size of the runner disk so that this wont happen (dont remember details, somewhere in the nf-core slack I think) but if you can adjust test files, thats preferable ofc.
I approve and think you will do whats necessary, if anything.
…put modes Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Thanks @d4straub !
I think thats when nf-core comes into p(l)ay :D. Not sure if that would be needed in this setting. I'll try to reduce the test input further: Could we try this? nf-core/test-datasets#2007 |
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
PR to fix #277
Key implementations:
pridepysdrf-pipelinesexport functionSteps happen during the
PIPELINE_INITIALISATIONsubworkflow.Tested successfully on PXD009752 (2 raw files), and PXD004894 (140 raw files)
Edit: WIP figuring out which Comet resource limits fit best for CI runners for the sdrf test
Edit edit: New test runs through, but no space on device. Will shrink sdrf sheet to only 1 file instead of 2 after review
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).