migrate to Dropshot API manager #141
Conversation
Created using spr 1.3.6-beta.1
sunshowers
changed the title
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
| #[clap(name = "dpd")] | ||
| pub(crate) enum Args { | ||
| /// Run the Dendrite API server. | ||
| Run(Box<Opt>), |
There was a problem hiding this comment.
Now that we only have the run command, we can just drop the subcommand structure entirely.
There was a problem hiding this comment.
In general, we've retained the subcommand structure in other servers even if it's the only command.
If you still think we should get rid of the run command, can this be a followup? Would have to update all the places that run the binary as well, which adds risk for something that's pretty time-constrained.
There was a problem hiding this comment.
If our standard practice is to keep the vestigial run subcommand, I'm fine with that.
There was a problem hiding this comment.
Thanks -- see https://github.com/oxidecomputer/omicron/blob/5f7ab65c8c8b215c6cf71b0d6e018574aa2e7f92/sled-agent/src/bin/sled-agent.rs#L25-L31 for an example. I guess one advantage is that if we do need to add a second command in the future, the places that run the binary don't have to be updated again.
Part of oxidecomputer/omicron#8922.