Skip to content

Conversation

@MattWellie
Copy link
Contributor

@MattWellie MattWellie commented Jan 21, 2026

I've been using this to check the performance of populationgenomics/cpg-flow#150

During that testing there were a few hiccups - the base image now contains the wrong version of python, the linting setup was well out of date, and various other syntax oddities.

Update to modernise the test workflow:

  • don't use default images (US region), instead - set an image for each job
  • remove >100 pre-commit ignored rules, and adjust code to pass new inspections
  • update to 3.11 and Hail 0.2.137
  • various little updates following lint-ignore changes (e.g. limiting number of method arguments, rearranging imports to reflect isort rules)
  • changed the job method and the job class for each stage to have different names (my local linter was really unhappy about the previous state - stages.py was importing jobs.name, and due to init.py this was actually importing jobs.name.name, so the linter saw it as a name clash)
  • removed the init.py implicit import for Stage jobs, and move to explicitly referencing the stage job method

Successful test run here https://batch.hail.populationgenomics.org.au/batches/1124257

@MattWellie MattWellie requested a review from a team as a code owner January 21, 2026 04:41
@MattWellie
Copy link
Contributor Author

Closed in favor of the stacked PR chain #19, #20, #21

@MattWellie MattWellie closed this Jan 22, 2026
@MattWellie MattWellie deleted the tws_update branch January 22, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants