fix(stages): modernise syntax #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #18 2/3
A few syntax tweaks:
job/__init__.pyto implicitly gather methods. The previous solution meant thatfrom jobs import build_pyramidcould refer to the module or the method, and was flagged by the linter as a namespace collisionhail_batch.get_batch()) is accessed. Previously this was accessed instages.pyand passed as a method argument to every job. Here it is accessed where needed, and never passed as a method.self.expected_outputsis only called once per Stage, and the results are reused.read_inputandwrite_outputmethods only tolerated Strings; changed since Hail 0.2.133.is replaced with:
job.command("...")