depend on libnvjitlink-dev at build time unconditionally#5479
depend on libnvjitlink-dev at build time unconditionally#5479rapids-bot[bot] merged 5 commits intorapidsai:mainfrom
Conversation
Proposes allowing all `wheels-build` jobs to run to completion, instead of immediately cancelling all of them when 1 fails. This should help with narrowing down issues, like "only fails on arm64". ## Motivation Noticed while working on rapidsai/cugraph#5479, where @ChuckHastings and I were investigating an issue that only occurred on CUDA 12 builds. Noticed that all `conda-cpp-build` jobs ran to completion, but `wheels-build` jobs were cancelled after the first failure. <img width="1837" height="733" alt="image" src="https://github.com/user-attachments/assets/70459440-e8b0-4a16-b955-b1a22452d11e" /> ## Notes for Reviewers This change will increase CI runner usage, but I think it's worth it: * CPU-only runners used for builds are generally cheap and plentiful * failed wheel build jobs are valuable: - they provide information to speed up debugging (e.g. "only fails on arm64") - they partially fill up the shared build caches and package caches, which other CI jobs benefit from and which might reduce the time-to-resolution for issues Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Bradley Dice (https://github.com/bdice) URL: #517
|
Now that rapidsai/cuvs#1963 is merged, pushed an empty commit to re-run all CI. Hopefully we will see builds pass here now. |
|
/merge |
|
All wheel tests are failing like this: Just seeing that it's in I'll go get some new |
|
Once rapidsai/raft#2991 is merged (or any other RAFT PR, if another gets there sooner) and there are new nightly packages, I'll restart CI here. |
To adapt to recent changes in other RAPIDS projects, we need to produce new nightly wheels from this project (rapidsai/cugraph#5479 (comment)). Today, that requires merging a new commit (rapidsai/build-planning#218 documents why). Given that we need that anyway, this at least tries to make it a useful one... bumping a few `pre-commit` hook versions and consolidating duplicate uses of `pre-commit/pre-commit-hooks`. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #2991
…cugraph into fix/libnvjitlink-dependencies
|
New RAFT build finished (https://github.com/rapidsai/raft/actions/runs/23807692461/job/69387358843), just pushed a commit restarting CI here. This PR is already queued to auto-merge, so if CI passes it'll merge in and things should be working in this repo again. |
rapidsai/cuvs#1923 switched cuVS to always enabling JIT+LTO, and therefore requiring nvJitLink at build and runtime.
Previously, it had only been required for CUDA 13.
cuGraph pulls cuVS via CPM and builds it from source, but wasn't updated to match, resulting in CUDA 12 builds here failing like this:
(example build link)
This resolves that, by removing "if CUDA 13" types of guards around this project's libnvJitLink dependency.
Notes for Reviewers
Some builds may still fail here
Like this:
Until rapidsai/cuvs#1954 is resolved, which @viclafargue is working on in rapidsai/cuvs#1963