Use migrated message utility functions#209
Merged
jacobperron merged 1 commit intomasterfrom Apr 1, 2019
Merged
Conversation
jacobperron
force-pushed
the
migrate_message_utilities
branch
from
73fa7e9 to
d3f8e84
Compare
These functions are more generally useful outside of ros2topic and so they have been moved to rosidl_runtime_py. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
force-pushed
the
migrate_message_utilities
branch
from
d3f8e84 to
571d1eb
Compare
jacobperron
added
in review
Member
Author
|
dirk-thomas
approved these changes
Apr 1, 2019
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
* Initial commit * First version of integration test framework based on roslaunch2 * Add launch arguments to apex_rostest - Arguments work like regular launch arguments: apex_rostest name_of_test.py arg:=foo - Added a mesasge pump class that will spin some rclpy nodes on a background thread automatically * Make sequential output checker public * Use the print_arguments_of_launch_description function from ros2launch API * Add arg support to apex_rostest_cmake * Add more information to the junit XML * Change apex_rostest to apex_launchtest - Rename apex_rostest to apex_launchtest - Remove rclpy deps from apex_launchtest - Remove launch_ros deps from apex_launchtest - Move ros and rclpy deps into a new package, apex_launchtest_ros - Add two examples to apex_launchtest that don't require ROS - Update tests that used the ROS nodes previously in apex_rostest to use non ROS processes - Update license from "all rights reserved" to apache * Address PR comments * Address Dejan's review comments * Enable gitlab CI - Build and test apex_launchtest only - Build and test everything (apex_launchtest + apex_launchtest_ros) - Coverage report * Speed up the 'coverage' job * Address Hao's PR comments - Git rid of extra sh -c (left over from a copy/paste) - Build jobs only save 'build' and 'install' artifacts - test_all job saves 'build', 'install', 'log', and globs for .coverage files * Give extra information when processes die before tests are done * Fix coverage report - Use symlink-install, otherwise coverage we get through subprocess calls ends up in a different place than coverage we get through calling functions directly from tests * Have IO and Exit Code asserts use the same lookup - Gave all of these methods the same signature. They can all take ExecuteProcess actions or strings - New util to handle the lookup of process actions in one place * Address wjwwood's review comments * Docs and examples (ros2#10) * Initial README.md doc and improved example * Address review comments * Describe assertions * Describe arguments * Address second round of review comments * Update README.md One more round of addressing comments * Simple XML output check * Add scheduled job to check package deps - Do an isolated build from source to catch issues with missing deps - Add a line (commented) that will fail the build if rclpy is a dep for apex_launchtest - Set up job to run on a schedule (schedule will need to be added to CI) because it's very long * Remove rclpy dep - Remove ros2launch dep from apex_launchtest, which should also remove rclpy dep - Add test for the '--show-args' argument - enable CI check for rclpy dep * Test we're compatible with ros-crystal * Fix FailResult not serializing to XML - Give FailResult the VIP treatment by giving it the extra properties that the TestResult class has. * Add ability to pass objects from test_description to tests * Pass test context as arguments to test cases - If we pass the test_context dictionary items as kwargs to the tests, we don't need to worry about them colliding with other fields on the unittest.TestCase. Someone could still name a TestContext item "self" but I feel like they deserve what they get if they do that. - Refactor the method that iterates all test cases so it can be used to give attributes to test, as well as the new bind_test_context_to_tests method * Fix doc comments * apex_launchtest bind test args to setup functions * Try to figure out why test_isolated didn't notice we still depend on rclpy * Remove ros2launch.api dep with more copy/paste code * Make isolated build schedule-only again * apex_launchtest_ros make MessagePump work with context * apex_launchtest_cmake give option to increase timeout * apex_launchtest handle processes with no output - This bug happened when all of the processes under test crashed out from under us and we tried to print extra info to help debug the test failure, but at least one of the processes had no output * Add test for error process with no output * Add coverage on 0% covered files - use the 'source' option for coverage to pick up files not touched by any test. Currently, message_pump and apex_launchtest_ros/__init__.py because we're not running any of the ROS examples * reroot ApexAI repository into subfolder Signed-off-by: William Woodall <william@osrfoundation.org> * disable imported code Signed-off-by: William Woodall <william@osrfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions are more generally useful outside of ros2topic and so they have been moved to rosidl_runtime_py.
Requires ros2/rosidl_python#34