Merged
Conversation
This was referenced Mar 15, 2019
Member
Author
|
Member
Author
|
This was referenced Mar 15, 2019
jacobperron
added
in review
dirk-thomas
reviewed
Mar 27, 2019
Member
dirk-thomas
left a comment
dirk-thomas
left a comment
There was a problem hiding this comment.
Some of the code seems to be copied from other repos. Please provide exact links to the copied snippets to allow evaluating that they are the same. I think some of them might also have changed since this PR was created and need to be updated.
Migrated utility functions for working with Python ROS messages from the package `ros2topic`. Conversion implementation taken from: https://github.com/ros2/ros2cli/blob/978fc8807cb1f70b5f9c2b085e7b6fa74d191d0e/ros2topic/ros2topic/verb/echo.py Set message implementation taken from https://github.com/ros2/ros2cli/blob/978fc8807cb1f70b5f9c2b085e7b6fa74d191d0e/ros2topic/ros2topic/api/__init__.py#L93-L119 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Add docstrings and annotations. * Rename 'msg' -> 'message' * Add more tests * Remove default value from getattr in convert function * Remove custom SetFieldError exception Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
force-pushed
the
rosidl_runtime_py
branch
from
f51ca06 to
4171c5a
Compare
Member
Author
|
I've gone back and grabbed the latest code from Conversion implementation taken from: Set message implementation taken from: |
Member
Author
|
The subsequent replacement in ros2cli: ros2/ros2cli#209 |
dirk-thomas
approved these changes
Mar 28, 2019
Member
dirk-thomas
left a comment
dirk-thomas
left a comment
There was a problem hiding this comment.
I would suggest to merge without squashing to keep the two commits separate.
Member
Author
|
Thanks for the review!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated utility functions for working with Python ROS messages from the package
ros2topic.The intention is to reuse these functions in other CLI tools:
ros2serviceandros2action.Replaces ros2/rclpy#285.