Skip to content

Online bagger#162

Open
zrzz-hq wants to merge 17 commits intomainfrom
online_bagger
Open

Online bagger#162
zrzz-hq wants to merge 17 commits intomainfrom
online_bagger

Conversation

@zrzz-hq
Copy link
Contributor

@zrzz-hq zrzz-hq commented May 21, 2025

The first C++ version of the online bagger has been completed and is ready for testing on a vechicle. When would be a good time to test it?

@zrzz-hq zrzz-hq linked an issue May 21, 2025 that may be closed by this pull request
@zrzz-hq zrzz-hq requested review from DaniParr and cbrxyz May 21, 2025 14:25
@zrzz-hq zrzz-hq requested review from Carlosdc25 and removed request for DaniParr and cbrxyz June 10, 2025 20:02
@cbrxyz
Copy link
Member

cbrxyz commented Aug 15, 2025

Hey, thanks! Could you please add some instructions on running this?

@zrzz-hq
Copy link
Contributor Author

zrzz-hq commented Aug 15, 2025

You can type online_bagger help to display the help text. Also I'll add a README file later.

@zrzz-hq zrzz-hq requested a review from DaniParr October 24, 2025 12:48
Copy link
Contributor

@DaniParr DaniParr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the code looks good, but when you make future PRs could you provide screenshots / gifs / video links showing how to run your code and what it looks like to run the code.

After you show that it works I can rereview the code!

@zrzz-hq zrzz-hq added enhancement New feature or request cpp labels Oct 26, 2025
@zrzz-hq
Copy link
Contributor Author

zrzz-hq commented Oct 31, 2025

I remember we tested this on subjugator during this summer and it worked well. Carlos said he would approve the pull request but he hasn't.

@zrzz-hq zrzz-hq requested a review from DaniParr November 6, 2025 19:44
@wingdeans wingdeans self-requested a review February 2, 2026 18:16
@wingdeans
Copy link
Contributor

I'm not sure if we need an online bagger right now. Even if we did, the extra features (TUI, progress feedback, env vars?) make the program too large for what it should do. If you left, it would be hard to find a maintainer for this.

I'll bring it up at testing but I don't think we'll move forward with this.

@zrzz-hq
Copy link
Contributor Author

zrzz-hq commented Feb 4, 2026

The TUI is an extra feature. Progress feedback and env vars are not, they are parts of the original version.

@zrzz-hq
Copy link
Contributor Author

zrzz-hq commented Feb 4, 2026

I also suggest doing issue clean-ups regularly to remove unused or obsolete issues. Letting people spend time on tools that won’t be used in the future isn’t a good use of effort.

@wingdeans
Copy link
Contributor

I also suggest doing issue clean-ups regularly to remove unused or obsolete issues. Letting people spend time on tools that won’t be used in the future isn’t a good use of effort.

Agreed..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cpp enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make C++ online bagger

4 participants