Conversation
|
Hey, thanks! Could you please add some instructions on running this? |
|
You can type |
DaniParr
left a comment
There was a problem hiding this comment.
In general, the code looks good, but when you make future PRs could you provide screenshots / gifs / video links showing how to run your code and what it looks like to run the code.
After you show that it works I can rereview the code!
|
I remember we tested this on subjugator during this summer and it worked well. Carlos said he would approve the pull request but he hasn't. |
|
I'm not sure if we need an online bagger right now. Even if we did, the extra features (TUI, progress feedback, env vars?) make the program too large for what it should do. If you left, it would be hard to find a maintainer for this. I'll bring it up at testing but I don't think we'll move forward with this. |
|
The TUI is an extra feature. Progress feedback and env vars are not, they are parts of the original version. |
|
I also suggest doing issue clean-ups regularly to remove unused or obsolete issues. Letting people spend time on tools that won’t be used in the future isn’t a good use of effort. |
Agreed.. |
The first C++ version of the online bagger has been completed and is ready for testing on a vechicle. When would be a good time to test it?