Open
Conversation
wingdeans
force-pushed
the
dean-simulation-performance
branch
from
1fccc84 to
4603446
Compare
Carlosdc25
previously approved these changes
Oct 14, 2025
Contributor
Author
|
Somehow dismissed the review while checking the CI? |
Contributor
|
No there weren't any issues it just got lost in the merge |
Contributor
|
Although I do predict we might see issues with spanning objects in the future but that shouldn't be too hard to fix |
Carlosdc25
previously approved these changes
Oct 23, 2025
- switches from rgb+depth camera to plain rgb camera - limits buoyancy calculations to sub
wingdeans
force-pushed
the
dean-simulation-performance
branch
from
156987a to
e4bec75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #270