Skip to content

Refactor view model#233

Open
xizzhu wants to merge 11 commits intomasterfrom
refactor_view_model
Open

Refactor view model#233
xizzhu wants to merge 11 commits intomasterfrom
refactor_view_model

Conversation

@xizzhu
Copy link
Owner

@xizzhu xizzhu commented Jun 12, 2022

No description provided.

@xizzhu xizzhu self-assigned this Jun 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2022

Codecov Report

Merging #233 (40b994a) into master (674038e) will decrease coverage by 0.04%.
The diff coverage is 51.14%.

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   52.34%   52.29%   -0.05%     
==========================================
  Files         122      124       +2     
  Lines        4604     4740     +136     
  Branches      609      629      +20     
==========================================
+ Hits         2410     2479      +69     
- Misses       2119     2183      +64     
- Partials       75       78       +3     
Impacted Files Coverage Δ
...n/me/xizzhu/android/joshua/infra/BaseActivityV2.kt 0.00% <0.00%> (ø)
...android/joshua/progress/ReadingProgressActivity.kt 0.00% <0.00%> (ø)
.../me/xizzhu/android/joshua/search/SearchActivity.kt 0.00% <0.00%> (ø)
...ndroid/joshua/progress/ReadingProgressViewModel.kt 82.85% <74.28%> (-6.51%) ⬇️
...me/xizzhu/android/joshua/search/SearchViewModel.kt 92.19% <87.01%> (+0.77%) ⬆️
.../me/xizzhu/android/joshua/infra/BaseViewModelV2.kt 100.00% <100.00%> (ø)
...e/xizzhu/android/joshua/preview/PreviewViewData.kt 81.08% <100.00%> (+5.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 674038e...40b994a. Read the comment docs.

@xizzhu xizzhu force-pushed the refactor_view_model branch from f315626 to 46f2d2e Compare June 18, 2022 04:31
@xizzhu xizzhu force-pushed the refactor_view_model branch from 46f2d2e to f864b6f Compare June 18, 2022 06:13
@xizzhu xizzhu force-pushed the refactor_view_model branch 3 times, most recently from 125c374 to 56f3f49 Compare June 26, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants