pkg: tests: handle arch requirements at pkg level, remove useless board blacklist#12608
Merged
kaspar030 merged 34 commits intoRIOT-OS:masterfrom Nov 4, 2019
Merged
pkg: tests: handle arch requirements at pkg level, remove useless board blacklist#12608kaspar030 merged 34 commits intoRIOT-OS:masterfrom
kaspar030 merged 34 commits intoRIOT-OS:masterfrom
Conversation
aabadie
added
Area: tests
It is required at the package level
This is now automatically managed by the arch 32 feature requirement at pkg dependencies level
This is now automatically managed by the arch 32 feature requirement at pkg dependencies level
This is now automatically managed by the arch 32 feature requirement at pkg dependencies level
This is now automatically managed by the arch 32 feature requirement at pkg dependencies level
This is now automatically managed by the arch 32 feature requirement at pkg dependencies level
This is now automatically managed by the arch 32 feature requirement at pkg dependencies level
This is now automatically managed by the arch 32 feature requirement at pkg dependencies level
This is now automatically managed by the arch 32 feature requirement at pkg dependencies level
This is now automatically managed by the arch 32 feature requirement at pkg dependencies level
This is now automatically managed by the arch 16bit feature blacklist at pkg dependencies level
This is now automatically managed by the arch 16bit feature blacklist at pkg dependencies level
aabadie
force-pushed
the
pr/pkg/hacl_arch_32bit
branch
from
0d1c868 to
7a83364
Compare
Contributor
|
|
miri64
reviewed
Oct 30, 2019
This is now automatically managed by the arch 32 feature requirement at pkg dependencies level
Contributor
Author
|
Added a couple of commit for applying the same cleanup to the tinydtls package and the associated dtls-echo example. |
Remove 8 bit and 16 bit based boards because they are automatically excluded by the 32 bit architecture requirement of the jerryscript package
Remove 8 bit and 16 bit based boards because they are automatically excluded by the 32 bit architecture requirement of the jerryscript package
Contributor
Author
|
Added commits for lua and jerryscript packages. |
miri64
reviewed
Oct 30, 2019
Contributor
Author
Good idea. With the help of this script, below is the comparison. tests/pkg_cifraThis PR: master: diff: tests/pkg_cn-cborThis PR: master: diff: tests/pkg_haclThis PR: master: diff: tests/pkg_libcoapThis PR: master: diff: tests/pkg_libcoseThis PR: master: diff: tests/pkg_libhydrogenThis PR: master: diff: tests/pkg_micro-eccThis PR: master: diff: tests/pkg_monocypherThis PR: master: diff: tests/pkg_qdsaThis PR: master: diff: tests/pkg_tinycborThis PR: master: diff: tests/pkg_wolfsslThis PR: master: diff: tests/pkg_wolfcrypt-ed25519-verifyThis PR: master: diff: examples/dtls-echoThis PR: master: diff: examples/dtls-wolfsslThis PR: master: diff: examples/javascriptThis PR: master: diff: examples/lua_REPLThis PR: master: diff: examples/lua_basicThis PR: master: diff: |
MIPS based boards are now blacklisted at package level
MIPS based boards are now blacklisted at package level
RISCV based boards are now blacklisted at package level
aabadie
force-pushed
the
pr/pkg/hacl_arch_32bit
branch
from
17e978f to
357eaba
Compare
Contributor
Author
|
I reran the script from above with the last version of this PR and got the same results. |
Contributor
Author
|
@miri64, @kaspar030, I think we are good here. Do you still have concerns ? |
Member
|
My comments were addressed. |
Contributor
yet no ACK? |
Contributor
Author
|
Thank you for the reviews! |
Member
Sorry, didn't have the time to have a look beyond confirming that my comments were addressed last week. |
This was referenced Nov 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is using the recently added arch requirements in the dependency files at package level. This allows to remove the board blacklist used in package related tests/examples.
Only packages and their related tests/examples are affected by this PR.
Testing procedure
A green Murdock should be ok.
Issues/PRs references
Partial (but cleaner) alternative to #12577.